Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Fixed bug with responses not returning the new instance #207

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Fix | Fixed bug with responses not returning the new instance #207

merged 2 commits into from
Apr 30, 2023

Conversation

Sammyjo20
Copy link
Member

@Sammyjo20 Sammyjo20 commented Apr 30, 2023 •
edited
Loading

Fixes #204

@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

🚀 PR Summary

  • 🔧 Improved executeResponsePipeline method
    The method now returns a response instead of just "void", providing more useful information.

  • 🧪 Enhanced RequestTest
    Import statements were added for MockClient, MockResponse, and Utils to make the tests more effective.

  • 🧹 Tidying up code
    Removed an unused import, making the code cleaner and easier to read.

  • ⚠️ Updating unit test expectations
    Some tests have changed expectations to match the actual function outputs. Please update the tests to pass successfully. Keep up the great work! 😃

Sammyjo20
Sammyjo20 commented Apr 30, 2023
View reviewed changes
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit c2e4eee into v2 Apr 30, 2023
@Sammyjo20 Sammyjo20 deleted the fix/response-middleware-not-returning-new-instance branch May 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify response before sending it to the client
1 participant
@Sammyjo20