Feature | V2 Better Merging Pipeline #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
juse-less
reviewed
Jan 24, 2023
Co-authored-by: Juse Less <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some more improvements to the middleware pipelines, specifically switching to a
Pipeclass for each pipe which now contains the name. This means I no longer need a separate array for the pipe names and when merging pipelines, all the names can be brought across.The default fixture directory will now be created even when it doesn't exist. @simple-hacker @Gummibeer
Todo: Throw an exception if merging results in two of the same middleware?