Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbars for Toolbox and Layout | Studio #10455

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kale1d0code
Copy link
Contributor

Description

Fixes a regression which removed the independent scrollbars for the Toolbox and Layout elements within Layout Editor.

Motivation and Context

Scrolling in the layout editor has become troublesome.
It is no longer possible to scroll to the panel and field slot you want a field to appear in without the list of fields moving at the sametime.

This change makes it so that the list of fields and the field positions can be scrolled through independantly.

How To Test This

Open Studio and navigate through to the layout editor on a module with enough panels and fields to require scrollbars on both.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Jun 17, 2024

CLA assistant check
All committers have signed the CLA.

…ayout within Studio Layout Editor

Fixes a regression which removed the independent scrollbars for the Toolbox and Layout elements within Layout Editor.
@serhiisamko091184 serhiisamko091184 added Area: Studio Issues & PRs related to all things regarding studio & module builder Area: Styling Issues & PRs related to all things regarding styling Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review labels Jun 21, 2024
@serhiisamko091184
Copy link
Contributor

Hello @kale1d0code,

thanks for your contribution!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing and removed Status: Requires Code Review Needs the core team to code review labels Jul 11, 2024
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Sep 5, 2024
@jack7anderson7 jack7anderson7 merged commit 7fedf92 into salesagility:hotfix Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Studio Issues & PRs related to all things regarding studio & module builder Area: Styling Issues & PRs related to all things regarding styling Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants