Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a grammar error in FullAlbumSearch.qml #88

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

tuplasuhveli
Copy link
Contributor

Fixing a grammar error "there's no missing covers..." -> "there are no missing covers..."

Fixing a grammar error  "there's no missing covers..." -> "there are no missing covers..."
Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

I really appreciate it when translators do not indifferently translate source strings, but also consider their grammatical correctness and maybe also if they are well phrased and do make sense; and then provide feedback.

@Olf0 Olf0 merged commit 75f4255 into sailfishos-applications:devel Mar 27, 2024
1 check passed
Olf0 added a commit that referenced this pull request Apr 12, 2024
* Post release version increase to 0.3.5 (#85)

* [flowplayer.spec] Post release version increase

* [flowplayer.changes] Add stub for v0.3.5

* Update README.md

* Translate translations/flowplayer.ts in et (#86)
  100% translated source file: 'translations/flowplayer.ts'
on 'et'.
  Co-authored-by: Priit Jõerüüt (tlend) via transifex-integration[bot] <43880903 transifex-integration[bot]@users.noreply.github.com>

* [README.md] Add a feature

* [README.md] Use better link

* [README.md] Minimalistic wording improvement

* Update README.md

* Fixing a grammar error in FullAlbumSearch.qml (#88)
  Fixing a grammar error  "there's no missing covers..." -> "there are no missing covers..."

* Update utils.cpp (#87)
  Fixing a grammar error in several instances: "founded" -> "found"

* Implement proper sandboxing (SailJail) configuration (#77)

* [flowplayer.desktop] Implement a proper SailJail configuration
  Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.

* [FlowPlayer.cpp] Eliminate migration functions due to conflict with sandboxing

* [rpm/flowplayer.changes] Update for v0.3.5

* [CoverPage.qml] Fix string and run `lupdate`

---------

Co-authored-by: transifex-integration[bot] <43880903 transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: tuplasuhveli <139926936 [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants