Readme Updated #26
Merged
Readme Updated #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-viradiya
requested changes
Oct 11, 2019
README.md
Outdated
| ``` | ||
| The only difference here is you need to call `PermissionManager.requestPermissions` which takes an instance of Fragment/Activity as an additional parameter. | ||
| ## Support for Coroutines, LiveData & Kotlin DSL | ||
| Please refer respective module for support. |
There was a problem hiding this comment.
We can change the title to "Read more about Coroutines, LiveData & Kotlin DSL" and add hyperlinks for each readme file.
livedatapermission/README.MD
Outdated
|
|
||
| ### Observing permission request result | ||
| With just one simple step(implementing an interface) you are ready to observe the result of request. | ||
| Your Activity/Fragment must implement `setupObserver` method of [`PermissionObserver`](https://github.com/sagar-viradiya/eazypermissions/blob/e1a36d5fb3ad487ac22da9b18e9b4c848cfcb74c/livedatapermission/src/main/java/com/eazypermissions/livedatapermission/PermissionManager.kt#L115) interface which expose LiveData<[`PermissionResult`](common/src/main/java/com/eazypermissions/common/model/PermissionResult.kt)>. Here is the definition of [`PermissionObserver`](https://github.com/sagar-viradiya/eazypermissions/blob/e1a36d5fb3ad487ac22da9b18e9b4c848cfcb74c/livedatapermission/src/main/java/com/eazypermissions/livedatapermission/PermissionManager.kt#L115) |
There was a problem hiding this comment.
LiveData<[`PermissionResult`](common/src/main/java/com/eazypermissions/common/model/PermissionResult.kt)>
This relative path is no longer valid since this is not in top level README
try
../common/src/main/java/com/eazypermissions/common/model/PermissionResult.kt
There was a problem hiding this comment.
There are so many instances like this. Please make sure you change all and verify it is navigating properly.
|
Now things seems to be okay. Please check. |
sagar-viradiya
requested changes
Oct 12, 2019
livedatapermission/README.MD
Outdated
| ) | ||
| ``` | ||
|
|
||
| ### Observing permission request result |
There was a problem hiding this comment.
I have removed that extra "#". Please review now!
sagar-viradiya
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual readme for Coroutines, LiveData & Kotlin DSL has been created.