Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix logo image source path #954

Merged
merged 2 commits into from
Oct 7, 2022
Merged

docs: fix logo image source path #954

merged 2 commits into from
Oct 7, 2022

Conversation

kurt-liao
Copy link
Contributor

Description

Fix the logo source path in cn and tw documentation.

Requirements / Checklist

What does this Pull Request (PR) do?

Fix the logo source path in cn and tw documentation.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

Great! Thank you!

Just did a quick check .. there are more broken image links as it seems:

$ grep images/ *.md | sed 's/.*images/images/; s/[")?].*//' | xargs ls -l
ls: cannot access 'images/nerd-fonts-logo.png': No such file or directory
ls: cannot access 'images/fontforge-glyph-set-font-linux.png': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory
ls: cannot access 'images/nerd-fonts-logo.png': No such file or directory
ls: cannot access 'images/fontforge-glyph-set-font-linux.png': No such file or directory
ls: cannot access 'images/nerd-fonts-logo.png': No such file or directory
ls: cannot access 'images/fontforge-glyph-set-font-linux.png': No such file or directory
ls: cannot access 'images/faux-shield-badge-os-logos.svg': No such file or directory

@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

A smarter search...

$ grep images/ *.md | sed 's/.*images/images/; s/[")?].*//' | xargs ls -l 2>&1 | grep cannot | sed "s/.* '//;s/'.*//" | sort | uniq
images/faux-shield-badge-os-logos.svg
images/fontforge-glyph-set-font-linux.png
images/nerd-fonts-logo.png

set-font-linux is now set-font-logos, but what was this faux-shield-badge? 🤔

@kurt-liao
Copy link
Contributor Author

kurt-liao commented Oct 7, 2022 •
edited
Loading

Command so smart! I just found that by my eyes when I was reading the docs, lol.

@kurt-liao
Copy link
Contributor Author

kurt-liao commented Oct 7, 2022 •
edited
Loading

After deep comparing the current version of docs, it seems cn and tw docs are out of date.

Maybe I fix all of them and create a new pr to it.

@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

Thank you. I already added a commit along the way.

The faux-badge thing comes from the wiki ... what a website design 😬

@Finii Finii merged commit e459f55 into ryanoasis:master Oct 7, 2022
@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

Well, I can not read the translations :-(

It is always hard to update them, I try to do my best, but over time I guess the text itself gets more and more ridiculous.

Thanks again for reporting and fixing 👍

@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

After deep comparing the current version of docs, it seems cn and tw docs are out of date.

Maybe I fix all of them and create a new pr to it.

That would be wonderful!!

@kurt-liao
Copy link
Contributor Author

Thank you. I already added a commit along the way.

The faux-badge thing comes from the wiki ... what a website design grimacing

I see. Thanks👍

@kurt-liao
Copy link
Contributor Author

Well, I can not read the translations :-(

It is always hard to update them, I try to do my best, but over time I guess the text itself gets more and more ridiculous.

Thanks again for reporting and fixing 1

Agree! Translation is always the hard part. Obviously, my English isn't good enough😅

I will finish the translation ASAP.

@Finii
Copy link
Collaborator

Finii commented Oct 7, 2022

@all-contributors please add @kurt-liao for documentation

@allcontributors allcontributors bot mentioned this pull request Oct 7, 2022
Merged
@allcontributors
Copy link
Contributor

@Finii

I've put up a pull request to add @kurt-liao! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurt-liao @Finii