make clearer where to add web-sys as dependency in Debugging chapter #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✋ A similar PR may already be submitted!
Please search 🔎 among the open pull requests before creating one.
Updating the Game of Life tutorial's code? Also send a PR to
rustwasm/wasm_game_of_life!Now that you've checked, it's time to create your PR. 📝
Thanks for submitting! 🙏
For more information, see the contributing guide. 👫
Summary
I made the mistake of adding web-sys twice, and also adding it right in the middle of the dependencies list, just like rustwasm/wasm-bindgen#1039.
I believe this small change makes it clearer where to add web-sys as a dependency with features.