Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'adding a line to dependencies' to 'adding dependencies' #196

Merged
merged 1 commit into from
Oct 24, 2019
Merged

change 'adding a line to dependencies' to 'adding dependencies' #196

merged 1 commit into from
Oct 24, 2019

Conversation

petosorus
Copy link

Summary

Explain the motivation for making this change. What existing problem does the pull request solve?
Non npm users might get confused when they can't find a dependencies field in the package.json file.
I just did an npm init wasm-app following the tutorial, and package.json now only has devDependencies out of the box.

Fixes #195

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fitzgen fitzgen merged commit 7d50dc6 into rustwasm:master Oct 24, 2019
@petosorus
Copy link
Author

👍

@petosorus petosorus deleted the npm_init_evolution branch October 24, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The line to add to package.json after npm init may be unclear
2 participants