rename init() to init_panic_hook()
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if this function is named `init` it will conflict with `init` function in the code generated by `wasm-build --target web`
it would produce code like:
```js
/**
*/
export function init() {
wasm.init();
}
// ...
function init(module) {
if (typeof module === 'undefined') {
module = import.meta.url.replace(/\.js$/, '_bg.wasm');
// ...
```
and parsing will fail with:
```
SyntaxError: unknown: Identifier 'init' has already been declared (136:9)
134 | }
135 |
> 136 | function init(module) {
| ^
137 | if (typeof module === 'undefined') {
138 | module = import.meta.url.replace(/\.js$/, '_bg.wasm');
139 | }
```
|
The book's tutorial doesn't use |
|
Oh oops disregard the last comment, I thought this was in the game of life tutorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this function is named
initit will conflict withinitfunction in the code generated bywasm-build --target webit would produce code like:
and parsing will fail with: