Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Examples) Bugfix: Use normal brackets to avoid docopt literal default #2009

Merged
merged 1 commit into from
Jun 18, 2024
Merged

(Examples) Bugfix: Use normal brackets to avoid docopt literal default #2009

merged 1 commit into from
Jun 18, 2024

Conversation

ckcr4lyf
Copy link
Contributor

The current text will make the docopt parsing use the literal value "inner-hostname" as the default.

From the application code:

rustls/examples/src/bin/ech-client.rs

Line 138 in 7d998cd

args.flag_host.as_ref().unwrap_or(&args.arg_inner_hostname),

it seems like the intention was to use the value OF inner-hostname if no override is provided.

Observed Behavior

$ cargo run --package rustls-examples --bin ech-client -- rfc5746.mywaifu.best rfc5746.mywaifu.best

HTTP/1.1 307 Temporary Redirect
Server: nginx/1.25.4
Date: Tue, 18 Jun 2024 09:54:50 GMT
Content-Type: text/html
Content-Length: 171
Location: https://inner-hostname/result/index.html?ech_status=success&ech_inner_sni=rfc5746.mywaifu.best&ech_outer_sni=example.com
Connection: close

<html>
<head><title>307 Temporary Redirect</title></head>
<body>
<center><h1>307 Temporary Redirect</h1></center>
<hr><center>nginx/1.25.4</center>
</body>
</html>

Expected Behavior

The hostname should have defaulted to rfc5746.mywaifu.best instead of inner-hostname .

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (7d998cd) to head (dd1cb87).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2009    /-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          97       97           
  Lines       21640    21640           
=======================================
  Hits        20382    20382           
  Misses       1258     1258

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for the fix :-)

@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3911873 3981938 70065 (1.79%) 5.07%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4388271 4417000 28729 (0.65%) 2.75%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13781345 13736154 -45191 (-0.33%) 1.03%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32924282 33022568 98286 (0.30%) 0.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30639805 30569452 -70353 (-0.23%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13768580 13799217 30637 (0.22%) 0.79%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2132871 2137244 4373 (0.21%) 0.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8699419 8717161 17742 (0.20%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13422541 13397818 -24723 (-0.18%) 0.77%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46432684 46506436 73752 (0.16%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3917406 3921774 4368 (0.11%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30689626 30658878 -30748 (-0.10%) 0.39%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33230754 33199236 -31518 (-0.09%) 0.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3382551 3379684 -2867 (-0.08%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3385410 3383871 -1539 (-0.05%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30857355 30871065 13710 (0.04%) 0.31%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32915759 32928744 12985 (0.04%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8705583 8702991 -2592 (-0.03%) 0.91%
handshake_session_id_ring_1.2_rsa_aes_server 4247544 4246367 -1177 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2234215 2233603 -612 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3990902 3989963 -939 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58267206 58280823 13617 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1914986 1914559 -427 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80662677 80645092 -17585 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43662070 43652859 -9211 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42002930 41994100 -8830 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92734624 92751347 16723 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30834721 30840170 5449 (0.02%) 0.42%
handshake_no_resume_ring_1.2_rsa_aes_client 2853523 2853059 -464 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30843439 30847955 4516 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42064161 42069094 4933 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4317534 4317072 -462 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4291642 4291199 -443 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4524943 4525405 462 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016160 2016364 204 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43727951 43731976 4025 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2226761 2226559 -202 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58256439 58261613 5174 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46391327 46387279 -4048 (-0.01%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2135554 2135378 -176 (-0.01%) 0.85%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80507815 80503157 -4658 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4288353 4288595 242 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30617323 30618647 1324 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30821309 30822630 1321 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30642982 30644075 1093 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33205571 33204496 -1075 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43444946 43446321 1375 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2950549 2950457 -92 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30839195 30840140 945 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13739310 13738913 -397 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33204595 33203652 -943 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41798286 41799440 1154 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42063137 42064278 1141 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33180569 33179676 -893 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32901090 32901938 848 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2956361 2956286 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12183119 12182810 -309 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12176945 12176653 -292 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41894144 41893213 -931 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43345983 43345051 -932 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43449667 43448746 -921 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43350470 43349585 -885 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92649105 92647268 -1837 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43657677 43656840 -837 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13741368 13741109 -259 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30658794 30659292 498 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716697 92718175 1478 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475499 35474948 -551 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920489 3920429 -60 (-0.00%) 0.45%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33175276 33174787 -489 (-0.00%) 0.57%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41875354 41875956 602 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11988287 11988115 -172 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42081742 42082340 598 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43732357 43731791 -566 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92719139 92720294 1155 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1911421 1911398 -23 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473513 35473092 -421 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42013400 42013898 498 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46433104 46432617 -487 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43447210 43447664 454 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4680840 4680887 47 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32942544 32942257 -287 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46434409 46434804 395 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46434305 46433913 -392 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32900807 32901084 277 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41795159 41794813 -346 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32942168 32941898 -270 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58315209 58315669 460 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80612154 80612716 562 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43729755 43729465 -290 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43654221 43653937 -284 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4255026 4255052 26 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92647432 92647997 565 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33179541 33179345 -196 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46451030 46451286 256 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41813432 41813653 221 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30632815 30632973 158 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80511037 80511445 408 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30862853 30863003 150 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58197944 58198206 262 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319359 58319115 -244 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92651851 92652197 346 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68660338 68660085 -253 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43349200 43349044 -156 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46443059 46443225 166 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46357041 46357195 154 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41875738 41875870 132 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41994817 41994944 127 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80519334 80519565 231 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58262644 58262550 -94 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80613104 80613166 62 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58313738 58313745 7 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.57 ms 0.05 ms (1.03%) 6.05%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.46 ms 5.52 ms 0.06 ms (1.01%) 4.80%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.24 ms 5.29 ms 0.05 ms (0.92%) 5.13%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.48 ms 5.52 ms 0.04 ms (0.80%) 4.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 481.43 µs 485.20 µs 3.77 µs (0.78%) 2.66%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 480.11 µs 483.74 µs 3.62 µs (0.75%) 3.14%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.69 µs 511.46 µs 3.77 µs (0.74%) 2.86%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.35 ms 6.40 ms 0.05 ms (0.74%) 3.66%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.80 ms 0.05 ms (0.71%) 3.52%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.25 µs 508.61 µs 3.35 µs (0.66%) 2.41%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.88 ms 0.04 ms (0.65%) 3.51%
handshake_tickets_ring_1.2_rsa_aes 1.64 ms 1.65 ms 0.01 ms (0.65%) 1.18%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.45 ms 9.50 ms 0.05 ms (0.53%) 2.71%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.23 ms 2.24 ms 0.01 ms (0.45%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.53 ms 0.05 ms (0.40%) 1.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.39 ms 0.02 ms (0.38%) 1.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.75 ms 0.05 ms (0.36%) 1.89%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 13.04 ms 0.05 ms (0.35%) 2.01%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.94 ms 13.99 ms 0.05 ms (0.35%) 1.84%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 13.04 ms 0.04 ms (0.34%) 1.80%
handshake_session_id_ring_1.2_rsa_aes 1.56 ms 1.56 ms 0.00 ms (0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.35 ms 5.37 ms 0.02 ms (0.30%) 1.68%
handshake_no_resume_ring_1.2_rsa_aes 978.80 µs 981.74 µs 2.94 µs (0.30%) 1.14%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.13 ms 0.05 ms (0.30%) 1.42%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.36 ms 0.02 ms (0.27%) 1.78%
handshake_no_resume_ring_1.3_rsa_aes 988.57 µs 991.21 µs 2.64 µs (0.27%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 989.08 µs 991.71 µs 2.63 µs (0.27%) 1.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.40 ms 0.01 ms (0.26%) 2.07%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.19 ms 0.00 ms (0.26%) 1.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.05 ms 6.07 ms 0.02 ms (0.25%) 1.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.08 ms 6.10 ms 0.02 ms (0.25%) 1.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.11 ms 0.01 ms (0.24%) 2.02%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.31 ms 6.32 ms 0.01 ms (0.22%) 1.84%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.09 ms 6.10 ms 0.01 ms (0.21%) 1.87%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.37 ms 1.37 ms 0.00 ms (0.21%) 3.16%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.40 ms 0.01 ms (0.20%) 2.36%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.42 ms 0.00 ms (0.20%) 3.53%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.35 ms 0.01 ms (0.18%) 2.04%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.09 ms 0.00 ms (0.17%) 1.88%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.70 ms 6.71 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.00 ms (0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.75 ms 6.76 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.43 ms 1.43 ms 0.00 ms (0.14%) 3.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.36 ms 0.01 ms (0.13%) 1.67%
handshake_tickets_ring_1.3_rsa_chacha 7.21 ms 7.22 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.23 ms 7.24 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.84 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.73 ms 6.74 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.82 ms 9.83 ms 0.01 ms (0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.87 ms 9.87 ms 0.01 ms (0.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.78 ms 6.78 ms 0.01 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.19 ms 7.20 ms 0.01 ms (0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.79 ms 9.80 ms 0.01 ms (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.26 ms 7.27 ms 0.00 ms (0.03%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.03%) 1.00%

Additional information

Historical results

Checkout details:

@cpu cpu added this pull request to the merge queue Jun 18, 2024
Merged via the queue into rustls:main with commit acc9fe5 Jun 18, 2024
25 checks passed
@cpu cpu mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckcr4lyf @cpu