-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: aws-lc-rs 1.6.2 -> 1.6.4 #1888
Conversation
Notably this brings in pre-generated bindings for more platforms. See the upstream release notes[0][1] for more details. [0]: https://github.com/aws/aws-lc-rs/releases/tag/v1.6.3 [1]: https://github.com/aws/aws-lc-rs/releases/tag/v1.6.4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 /- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 86 86
Lines 18624 18624
=======================================
Hits 17784 17784
Misses 840 840 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Those look like potentially substantial handshake latency regressions? |
@justsmth Is there something top-of-mind for you that might explain performance differences between 1.6.2 and 1.6.4? 🤔 |
@djc Looking at the results closer it seems like the significant changes in the wrong direction are isolated to the instruction count benchmarks that we know can be a less accurate measure of the real world performance. The wall-time benchmarks look OK to me. Which benchmarks seem concerning to you? |
Short answer is that I'm not aware of any significant performance regression, but I potentially can provide insight for changes in RSA-related latencies.
I'll check our internal metrics on RSA and follow-up with you. |
Notably this brings in pre-generated bindings for more platforms. See the upstream release notes12 for more details.
aws-ls-rs diff.rs
Footnotes
https://github.com/aws/aws-lc-rs/releases/tag/v1.6.3 ↩
https://github.com/aws/aws-lc-rs/releases/tag/v1.6.4 ↩