Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new Simulation section under Applications #1249

Merged
merged 4 commits into from
Mar 26, 2022

Conversation

Alfred-Mountfield
Copy link
Contributor

No description provided.

README.md Outdated
@@ -299,6 300,10 @@ See also [A comparison of operating systems written in Rust](https://github.com/
* [ripasso](https://github.com/cortex/ripasso/) — A password manager, filesystem compatible with pass
* [rustscan/rustscan](https://github.com/RustScan/RustScan) — Make Nmap faster with this port scanning tool [![build badge](https://github.com/RustScan/RustScan/workflows/Continuous integration/badge.svg?branch=master)](https://github.com/RustScan/RustScan/actions?query=workflow:"Continuous integration")

### Simulation

* [hEngine](https://github.com/hashintel/hash) - A Rust-implemented computational simulation engine, supporting large-scale agent-based modelling, with simulation logic written in JavaScript and Python.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo appears to be for something called HASH, not hEngine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, the link is to the HASH (company) monorepo which contains the hEngine. The hEngine is directly signposted from the root README so I thought it'd be better to point at the repository rather than a subfolder in case the folder structure changes and invalidates the link.

Is that problematic, should I change it to something?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link to the subfolder instead, as that's less confusing for day-to-day users (and myself TBH!) and I'm assuming won't be moving that often...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, would it be less confusing if I titled it as HASH Engine here? Which is the full name anyway. Otherwise yeah I'm happy to link the subfolder and try and get a process in place to remember to update it if the folder structure does change

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only hEngine appears to be Rust, so please link to that. The rest of the project isn't relevant to this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's fair :) have updated!

@palfrey palfrey enabled auto-merge March 26, 2022 20:27
@palfrey palfrey merged commit c7a835d into rust-unofficial:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants