Fixes for x86-interrupt calling convention
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
phil-opp
force-pushed
the
x86-interrupt-cc
branch
from
d225cff to
204edcc
Compare
|
Published as v0.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
x86-interruptcalling convention passes theInterruptStackFrameby value, not by reference: rust-lang/rust#40180 (comment). Apparently, by-ref worked as well before Rust upgraded to LLVM 12, but it no longer works on the latest nightlies. This pull request fixes the IDT to require a by-value stack frame parameter.Since modifying the interrupt stack frame now requires a volatile write, this PR changes the return type of the
InterruptStackFrame::as_mutfunction to aVolatile<_>reference.This is a breaking change.