make triagebot cuter #1756
Closed
make triagebot cuter #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noratrieb
reviewed
Dec 16, 2023
src/handlers/assign.rs
Outdated
| @@ -56,17 56,17 @@ const WELCOME_WITHOUT_REVIEWER: &str = "@Mark-Simulacrum (NB. this repo may be m | |||
|
|
|||
| const RETURNING_USER_WELCOME_MESSAGE: &str = "r? @{assignee} | |||
|
|
|||
| ({bot} has picked a reviewer for you, use r? to override)"; | |||
| ({bot} has picked a reviewer for you, use r? to override) (˶˃ᆺ˂˶)"; | |||
There was a problem hiding this comment.
I'm not sure whether this is appropriate here. Having a reviewer is something very positive, and they don't feel that happy to me. Maybe replace it with something more happy? The other ones fit very well though
There was a problem hiding this comment.
oh ok is this happy enough like this:
(*・ω・)ﾉ
|
tbh I find this addition not really necessary. Why?
edit: but I appreciate your intent to make new contributors feel somewhat more at ease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi i am new rust user can one of you experienced rust people review my code please