macros: add the permission to run performance #1469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on macros ofter is good to ask "we are introducing a regression in terms of performance?" So this commit is allowing the macros wg to use the perf bot. Link: rust-lang/rust#125828 Co-authored-by: Michael Goulet <[email protected]> Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/macros-web-page
branch
from
2a9e2a1
to
f454a21
Compare
|
I think conceptually it makes more sense to tie this permission to Compiler Contributors instead, and recognize that we expect a lot of wg-macro members will also be Compiler Contributors. |
Make a lot of sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on macros ofter is good to ask "we are introducing a regression in terms of performance?"
So this commit is allowing the macros wg to use the perf bot.
Link: rust-lang/rust#125828
cc @rust-lang/wg-macros