Improve rustls CA certificate loading #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ARM build that failed did so because of an incomplete installation: |
|
Totally badass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an enhancement to #568, add a basic cross-platform CA certificate loading crate and make the download crate use it when compiled with rustls support.
The CA loader crate has seen preliminary testing on Windows, OS X, and a couple of Linux distros. It loads the system root CAs on all of those, with the caveats that a) on CentOS, the default CA bundle contains a line which is invalid UTF-8; a fix for rustls to be more robust is ready and a PR will be opened presently, b) Windows and OS X don't use any kind of local policy to filter out certificates, so all certs which can be enumerated are trusted, c) *BSDs, Android, and Solaris haven't seen any testing.
The loader crate presently lacks any documentation and its error handling is rudimentary. That is being worked on.