Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): update DisplayVersion on rustup self update #3770

Merged
merged 11 commits into from
Apr 21, 2024
Merged

fix(windows): update DisplayVersion on rustup self update #3770

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift click to select a range
93e93c1
refactor(self-update): extract `do_update_programs_display_version()`
rami3l Apr 12, 2024
d8aacc1
refactor(self-update): extract `get_and_parse_new_rustup_version()`
rami3l Apr 12, 2024
5c5641b
fix(self-update): run `do_update_programs_display_version()` on `run_…
rami3l Apr 12, 2024
28cd72f
feat(self-update): improve error messages on Windows
rami3l Apr 14, 2024
eba295f
fix(self-update): replace some `#[cfg(not(unix))]` usages with `#[cfg…
rami3l Apr 15, 2024
ca6a1f0
refactor(self-update): use `std::io`
rami3l Apr 21, 2024
4b9503d
refactor(self-update): extract `with_saved_global_state()`
rami3l Apr 15, 2024
0aa766f
refactor(self-update): extract `(get|restore)_reg_value()`
rami3l Apr 15, 2024
90b22e2
feat(self-update): add `with_saved_reg_value()`
rami3l Apr 21, 2024
b1d1adf
test(self-update): ensure the resolution of #3739
rami3l Apr 21, 2024
8fcb223
refactor(self-update)!: remove confusing `get_path()` impl on Unix
rami3l Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(self-update): extract get_and_parse_new_rustup_version()
  • Loading branch information
@rami3l
rami3l committed Apr 21, 2024
commit d8aacc1bc91491eb31bfaadcae400b453ae2ff5a
13 changes: 7 additions & 6 deletions src/cli/self_update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,12 1106,9 @@ pub(crate) fn update(cfg: &Cfg) -> Result<utils::ExitCode> {

match prepare_update()? {
Some(setup_path) => {
let version = match get_new_rustup_version(&setup_path) {
Some(new_version) => parse_new_rustup_version(new_version),
None => {
err!("failed to get rustup version");
return Ok(utils::ExitCode(1));
}
let Some(version) = get_and_parse_new_rustup_version(&setup_path) else {
err!("failed to get rustup version");
return Ok(utils::ExitCode(1));
};

let _ = common::show_channel_update(
Expand All @@ -1135,6 1132,10 @@ pub(crate) fn update(cfg: &Cfg) -> Result<utils::ExitCode> {
Ok(utils::ExitCode(0))
}

fn get_and_parse_new_rustup_version(path: &Path) -> Option<String> {
rbtcollins marked this conversation as resolved.
Show resolved Hide resolved
get_new_rustup_version(path).map(parse_new_rustup_version)
}

fn get_new_rustup_version(path: &Path) -> Option<String> {
match Command::new(path).arg("--version").output() {
Err(_) => None,
Expand Down