fix(windows): update DisplayVersion on rustup self update
#3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
fix/windows-display-version
branch
4 times, most recently
from
2bc5572
to
e7cfe18
Compare
rami3l
force-pushed
the
fix/windows-display-version
branch
2 times, most recently
from
f011e8f
to
aaabd12
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rami3l
commented
Apr 12, 2024
rami3l
force-pushed
the
fix/windows-display-version
branch
from
aaabd12
to
b0ac7a6
Compare
rami3l
force-pushed
the
fix/windows-display-version
branch
3 times, most recently
from
87c81be
to
3ad9ea6
Compare
rbtcollins
reviewed
Apr 14, 2024
rbtcollins
reviewed
Apr 14, 2024
rbtcollins
reviewed
Apr 14, 2024
rami3l
force-pushed
the
fix/windows-display-version
branch
from
3ad9ea6
to
a6d6716
Compare
rami3l
force-pushed
the
fix/windows-display-version
branch
from
a6d6716
to
51fe36c
Compare
djc
approved these changes
Apr 14, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rami3l
force-pushed
the
fix/windows-display-version
branch
3 times, most recently
from
2362001
to
65858d8
Compare
3 tasks
rami3l
force-pushed
the
fix/windows-display-version
branch
from
65858d8
to
cd3511e
Compare
rami3l
commented
Apr 21, 2024
rami3l
commented
Apr 21, 2024
rami3l
force-pushed
the
fix/windows-display-version
branch
4 times, most recently
from
e4c88d7
to
e4cae16
Compare
rami3l
force-pushed
the
fix/windows-display-version
branch
from
e4cae16
to
8fcb223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3739.
My daily driver is a Mac (and OpenSSL refuses to cross-build here) so this is pretty much a best-effort blind fix.
cc @ChrisDenton
Concerns
Is it necessary to add a test case for this one? If so, how? (Considering the sandboxing requirements, doing this properly might be hard.)A sandboxed test case has been added.