Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui test for the rustup-init.sh #3209

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Add ui test for the rustup-init.sh #3209

merged 2 commits into from
Feb 19, 2023

Conversation

Rustin170506
Copy link
Member

Add UI test for the rustup-init.sh. Also compare two help texts to make sure they are equal.

@Rustin170506

This comment was marked as outdated.

Sign in to view
@Rustin170506 Rustin170506 changed the title Add ui test for the rustup-init.sh [WIP] Add ui test for the rustup-init.sh Feb 12, 2023
@Rustin170506 Rustin170506 changed the title [WIP] Add ui test for the rustup-init.sh Add ui test for the rustup-init.sh Feb 13, 2023
@Rustin170506 Rustin170506 marked this pull request as ready for review February 13, 2023 01:10
@Rustin170506 Rustin170506 force-pushed the rustin-patch-rust-init-sh-ui branch 4 times, most recently from 9d513b6 to 00c930f Compare February 19, 2023 08:33
@Rustin170506
Copy link
Member Author

Thanks for your review again! 💚 💙 💜 💛 ❤️

@Rustin170506 Rustin170506 merged commit 26fea62 into rust-lang:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtcollins rbtcollins rbtcollins approved these changes

@kinnison kinnison Awaiting requested review from kinnison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rustin170506 @rbtcollins