Remove trailing slashes in toolchain name #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnison
suggested changes
Nov 11, 2021
There was a problem hiding this comment.
There's a commit which needs removing; also also we need a test to demonstrate the issue and then demonstrate it is resolved by this patch. If you need some inspiration, check out cli-v2.rs which should have plenty of example tests you can crib from.
Thank you for your effort.
Rustin170506
approved these changes
Nov 19, 2021
ok clippy Revert "ok clippy" This reverts commit 7315538. add test for normalized toolchain name
sathwikmatsa
force-pushed
the
remove-trailing-slash
branch
from
c62e39e
to
3f3e0af
Compare
kinnison
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2873