Fixes #2807 adds info message if self-update is disabled #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If self-update is disabled via features during build time, then we should better info message during `update` that the `rustup` itself is not updated.
|
@carols10cents How do you feel about this - do you think it fixes #2807 in a way you think will work for others? |
kinnison
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If self-update is disabled via features during build time, then
we should better info message during
updatethat therustupitself is not updated.
How did I test?
cargo build --features no-self-updatemkdir homeRUSTUP_HOME=home CARGO_HOME=home target/debug/rustup-init --no-modify-path -yRUSTUP_HOME=home CARGO_HOME=home ./home/bin/rustup updateOutput from the last command: