#2572 - Add defaults to common::question_* #2605
Conversation
|
Fixes #2572 |
|
This covers the last of four questions - is there other work you have planned for the other questions hilighted in the issue you're fixing? |
|
Also I wonder if we might get a cli-exact test to cover this perhaps? |
|
I'll have a look at how to write those, this covers all 4 of the questions by adding the default to the end. |
|
So it does, I missed the effect of the first hunk. If we don't have any cli-exact tests doing prompted configuration then it ought to be fairly easy to add. If you want any help with that, ping me on Discord and if I'm around I'll do my best. |
|
Would it make more sense to do those tests in |
There was a problem hiding this comment.
The tests look good. Thank you for that.
This does indeed seem to do exactly what it says on the tin. It should indeed resolve the issue you set out to fix.
Before I can merge it I would like the commits cleanly rebased. A commit for the tests and a commit for the functionality would be best. Your choice which order to put them in.
If you need help doing that, ping me. Also if you're having difficulty with vscode formatting stuff, check that 'Editor: Format On Save' is set and that 'Editor: Format On Save Mode' is set to 'file'.
londospark
force-pushed
the
2572-indicate-default-option
branch
from
71f3909
to
a78d470
Compare
Hopefully this is cleaner than specifying the default as a string in each use of the
common::question_{str|bool}functions.