Fix #2229 detect available memory #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtcollins
force-pushed
the
2229
branch
3 times, most recently
from
53497af
to
5d88e2c
Compare
|
One possible critique of the patch is that I haven't wired up the UI to the eventing system. TBH I couldn't be bothered, but I can do that if thats the only issue. However I'm less and less enthralled by that system as time progresses; as we dont support the library as an API, and it's very cumbersome, I'd really like to bring a better system into being. |
kinnison
suggested changes
Feb 25, 2020
rbtcollins
force-pushed
the
2229
branch
2 times, most recently
from
a3a63c0
to
719ace8
Compare
kinnison
suggested changes
Feb 26, 2020
rbtcollins
force-pushed
the
2229
branch
3 times, most recently
from
f6d5cce
to
f1ff29a
Compare
This doesn't implement streaming IO for low memory situations - we still have the situation that low footprint situations will fail to install, but while it is the case that rustc's memory footprint is lower than our unpack footprint this is probably not urgent to fix, though I will get around to it. Being less aggressive about unpack buffer size though should reduce the number of support tickets from folk in these cases, I hope. We may end up getting tickets from folk with broken ulimit syscalls though, who knows.
kinnison
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't implement streaming IO for low memory situations - we still
have the situation that low footprint situations will fail to install,
but while it is the case that rustc's memory footprint is lower than our
unpack footprint this is probably not urgent to fix, though I will get
around to it.
Being less aggressive about unpack buffer size though should reduce the
number of support tickets from folk in these cases, I hope.
We may end up getting tickets from folk with broken ulimit syscalls
though, who knows.