Stop using bright colors #2083
Stop using bright colors #2083
Conversation
Bright colors often display badly for those who are using colorschemes that use unexpected bright colors such as solarized. Additionally, many terminals automatically display bold text in bright colors (unless this option is explicitly disabled) particularly if bold text is not supported. It should be left up to the user whether they want their bold text to be displayed in bright colors.
|
Thank you for your contribution. Could you please provide a couple of screenshots so that I can evaluate the visual difference between before and after for this PR? |
|
For example if I use my base-16 color scheme and choose not to display bold text in bright colors:
Then when displaying bright red, the text is actually displayed in orange:
This is even more problematic for bright green because the text is almost invisible. This PR results in the following colors instead
For those terminals that automatically display bold text in bright colors (in my experience most of them) this should have no effect. |
|
Here's an example for bright green text: Before: After: |
|
I can see how it makes a significant difference to readability for you, and I've tested it on my "normal" terminal and it's not sufficiently adversely affected to cause issues. I'm okay with this as a general readability improvement commit. |
|
Thanks! |
Bright colors often display badly for those who are using colorschemes
that use unexpected bright colors such as solarized.
Additionally, many terminals automatically display bold text in bright
colors (unless this option is explicitly disabled) particularly if bold
text is not supported.
It should be left up to the user whether they want their bold text to be
displayed in bright colors.
This should also fix #433 (if it is still an issue).