Do not list unavailable targets #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensions might have a target other than that of the toolchain so this change ensures we use the extension's target not the target of the toolchain when determining if it's available. This will as a result prevent `rustup target list` listing known but unavailable targets if `rust-std` is unavailable for that target. Signed-off-by: Daniel Silverstone <[email protected]>
Verify that targets which are not available are not listed when we look for targets in a toolchain. Signed-off-by: Daniel Silverstone <[email protected]>
|
AFAICS, the failures are the dist test timing out / crashing randomly on Windows CI - something we've not yet managed to reproduce outside of CI. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mistakenly listing targets as available when they were not, resulting in confusion when running
rustup target add all.This change ensures that we do not do that, by ensuring we use extension targets rather than the toolchain's target, when checking availability. We do not do this for components too at this time, since components are almost always the same arch as the rustc itself.