update shebang to reflect bashisms #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update shebang, given that `local` is not a POSIX semantic.
|
Looks like one of the macOS CI builds stalled for this tweak, dunno why? https://travis-ci.org/rust-lang-nursery/rustup.rs/jobs/290991285 |
|
If changing to bash using |
|
@mati865 Eh, if the shell were ash, dash, or posh, or relied on alpha features from Homebrew bash tip, then |
|
Thanks for the PR! |
Closed
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Oct 12, 2023
update shebang to reflect bashisms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update shebang, given that
localis not a POSIX semantic. Discovered this when trying to run the rustup installer on Oracle Solaris, where/bin/shis a symlink to ksh93.Note that the rustup.rs website should also pipe to
bash, notsh.Alternatively, we can rewrite this script in pure POSIX sh, though I leave that to cooler heads.