Alias 'rustup toolchain uninstall' to 'rustup uninstall' #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ‘rustup uninstall’ alias is patterned off of the implementation of ‘rustup install’. I’ve also added a test in cli-rustup.rs to verify.
|
@jordanhiltunen Thanks! I don't think we should add further aliases (such as Adding the uninstall alias seems fine to me though because of the symmetry with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #730.
This PR aliases
rustup toolchain uninstalltorustup uninstall, making uninstallation more symmetrical with installation, which already viewsrustup installandrustup toolchain installas equivalent.The
rustup uninstallalias is directly patterned off of the implementation ofrustup install. I’ve also added a test in cli-rustup.rs to verify.The issue linked also alludes to some confusing irregularities in the documentation (random flipping between use of 'update' and 'install'), and a softer question about whether
rustup toolchain removeshould be aliased torustup removeas well.This is my first crack at a PR here, so I was a bit sheepish to wade into those more contentious elements of the issue, but I would be glad to dig deeper into the semantic consistency of these various aliases if there's any interest, and someone thinks I'm headed in the right direction. Thanks!