-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the use of toolchain link #954
Labels
Comments
Thank you for the bug report @jonhoo ! |
typesanitizer
pushed a commit
to typesanitizer/rustup.rs
that referenced
this issue
Mar 29, 2017
…ng#954. * Also renamed TOOLCHAIN_INSTALL_HELP -> INSTALL_HELP for consistency.
PR submitted here: #1017 |
Would be great to also add some error checking, so if you try to |
|
At least a sanity check that bin, lib, and bin/rustc are in the expected
place would be nice.
…On Sat, Apr 1, 2017 at 12:04 AM, theindigamer ***@***.***> wrote:
1. @durka <https://github.com/durka>, what are all the things that
need to be checked before linking? In my build, I have a lot of .so
files inside stage1/lib and .rlib and .so files in
stage1/lib/x86_64-unknown-linux-gnu/lib.
2. I'm not sure which function should handle the error checking
though: toolchain_link calls install_from_dir which calls install
which calls run basically calls utils::symlink_dir. Which function's
responsibility would it be to handle this error? I suppose we could do it
in toolchain_link itself by just calling rustup_utils::utils::assert_
is_file for $path/bin/rustc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#954 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC3n8gVDX-pmZrGXWVvXfFQ2lcEtr9dks5rrcy9gaJpZM4L-rWz>
.
|
typesanitizer
pushed a commit
to typesanitizer/rustup.rs
that referenced
this issue
Apr 3, 2017
bors
added a commit
that referenced
this issue
May 9, 2017
Added help for `rustup toolchain link` as documented in issue #954. * Also renamed TOOLCHAIN_INSTALL_HELP -> INSTALL_HELP for consistency.
Looks like the original issue is fixed. Thanks @theindigamer. Do we need to open another issue for the followups mentioned here cc @durka @theindigamer ? |
Nope! Thanks @theindigamer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current output of
toolchain --help
mentions that "rustup
can also install toolchains from [..] local builds", but then does not go into further detail.toolchain link
is the command meant for that purpose, but its--help
output is, well, unhelpful:In particular, it should at the very least be noted that
path
should be/path/to/rust/build/$triple/stage1
, andlink
should be pointed to fromtoolchain --help
. It'd also be useful to mention that only arustc
build is required, not a fullcargo
build.The text was updated successfully, but these errors were encountered: