Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort toolchains numerically #668

Closed
dtolnay opened this issue Aug 19, 2016 · 2 comments
Closed

Sort toolchains numerically #668

dtolnay opened this issue Aug 19, 2016 · 2 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented Aug 19, 2016

1.10.0 after 1.9.0 (or before, if we do reverse numeric order).

$ rustup toolchain list
stable-x86_64-unknown-linux-gnu
beta-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu (default)
1.0.0-x86_64-unknown-linux-gnu
1.1.0-x86_64-unknown-linux-gnu
1.10.0-x86_64-unknown-linux-gnu
1.11.0-x86_64-unknown-linux-gnu
1.2.0-x86_64-unknown-linux-gnu
1.3.0-x86_64-unknown-linux-gnu
1.4.0-x86_64-unknown-linux-gnu
1.5.0-x86_64-unknown-linux-gnu
1.6.0-x86_64-unknown-linux-gnu
1.7.0-x86_64-unknown-linux-gnu
1.8.0-x86_64-unknown-linux-gnu
1.9.0-x86_64-unknown-linux-gnu
@Boddlnagg
Copy link
Contributor

Boddlnagg commented Aug 20, 2016 •
edited
Loading

That sounds like a good idea to me! The sorting happens here. I think the right way to do this is by having a custom Ord impl for Component. Actually, the relevant function is toolchain_sort. Do you want to try implementing this? You can probably use https://crates.io/crates/natord.

@Boddlnagg Boddlnagg mentioned this issue Aug 24, 2016
Merged
@malbarbo
Copy link
Contributor

malbarbo commented Apr 5, 2017

This was fixed by #688

@Diggsey Diggsey closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Diggsey @Boddlnagg @malbarbo @dtolnay