Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexplained print with partial valid rust-toolchain.toml #3732

Closed
Matthew-Chidlow opened this issue Mar 23, 2024 · 2 comments · Fixed by #3734
Closed

Unexplained print with partial valid rust-toolchain.toml #3732

Matthew-Chidlow opened this issue Mar 23, 2024 · 2 comments · Fixed by #3734
Labels
bug
Milestone
1.27.1

Comments

@Matthew-Chidlow
Copy link

Problem

When running commands like rustup show an unexplained message is printed to console:

Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }) [Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }), Official(ToolchainDesc { channel:
"nightly", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "nightly", date: None, target: TargetTriple("x86_64-pc-windows-msvc") })]

This also happens when using cargo

Steps

  1. Create a rust project
  2. Add a rust-toolchain.toml file
  3. Put in the file something like:

[toolchain]
channel = "stable-x86_64-pc-windows-msvc"

where the channel listed contains a host triple and is an installed toolchain

  1. Try run almost any rustup or cargo command in the projects directory

Possible Solution(s)

I think the print is here:

rustup/src/config.rs

Line 863 in 1c612cf

eprintln!("{resolved_name:?} {ts:?}");

Probably should print some more context

Notes

No response

Rustup version

rustup 1.27.0 (bbb9276d2 2024-03-08)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }) [Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }), Official(ToolchainDesc { channel: 
"nightly", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "nightly", date: None, target: TargetTriple("x86_64-pc-windows-msvc") })]
info: The currently active `rustc` version is `rustc 1.77.0 (aedd173a2 2024-03-17)`

Installed toolchains

Default host: x86_64-pc-windows-gnu
rustup home:  C:\Users\Matthew\.rustup

Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }) [Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "stable", date: None, target: TargetTriple("x86_64-pc-windows-msvc") }), Official(ToolchainDesc { channel: 
"nightly", date: None, target: TargetTriple("x86_64-pc-windows-gnu") }), Official(ToolchainDesc { channel: "nightly", date: None, target: TargetTriple("x86_64-pc-windows-msvc") })]
installed toolchains
--------------------

stable-x86_64-pc-windows-gnu (default)
stable-x86_64-pc-windows-msvc
nightly-x86_64-pc-windows-gnu
nightly-x86_64-pc-windows-msvc

active toolchain
----------------

stable-x86_64-pc-windows-msvc (overridden by 'C:\Users\Matthew\RustroverProjects\fine_zoom_2\rust-toolchain.toml')
rustc 1.77.0 (aedd173a2 2024-03-17)
@rami3l
Copy link
Member

rami3l commented Mar 23, 2024

@rbtcollins did you happen to forget deleting this after print debugging?

@djc
Copy link
Contributor

djc commented Mar 23, 2024

Can probably just do a PR for this, seems highly likely that that is the case.

@rami3l rami3l added this to the 1.27.1 milestone Mar 23, 2024
@rami3l rami3l mentioned this issue Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.27.1
Development

Successfully merging a pull request may close this issue.

fix(config): remove unnecessary debug print rust-lang/rustup
3 participants
@djc @rami3l @Matthew-Chidlow