-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System-Rust-override warning is too scary #2726
Comments
This echoes the needs of #1490 so it is fine if it is closed as a duplicate, however the messaging is still really intense. |
I agree this is related #1490 but your point about the messaging is valid and could be resolved before we do anything more complex. As such I'd love it if someone would propose some relacement messages whose tone is a little more cautionary rather than scary. |
@rustbot label: O-linux |
I can concur with the scariness aspect, but I'd like to clarify something: what are distros doing that leads to rustc/cargo being installed as part of the distro for system dependencies? Unlike python rustc/cargo are only needed when building system components, so unless someone is developing system packages, they shouldn't need a distro packaged rustc/cargo, correct? |
Hello all, Here's what I'm seeing when I reproduce: fack@penguin:~$ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
info: downloading installer
warning: it looks like you have an existing installation of Rust at:
warning: /usr/bin
warning: rustup should not be installed alongside Rust. Please uninstall your existing Rust first.
warning: Otherwise you may have confusion unless you are careful with your PATH
warning: If you are sure that you want both rustup and your already installed Rust
warning: then please reply `y' or `yes' or set RUSTUP_INIT_SKIP_PATH_CHECK to yes
warning: or pass `-y' to ignore all ignorable checks.
error: cannot install while Rust is installed
Continue? (y/N) Is there desire to dampen the severity of this line specifically?
I think changing it to something more persuading like:
I've broken these lines up for legibility purposes. I can create a draft PR with these changes if folks like the verbiage. |
@facklambda I'd be very happy with your proposed rewording, sorry for taking so long to get back to you. If you're still interested in producing a PR, please do. |
If a user installs Rust from Rustup, they probably want to install Rust from Rustup. They should be clearly and explicitly cautioned about what is happening, but the message should not try to implicitly dissuade them from continuing, as many package managers are now delivering Rust for system dependencies. Instead, it should be relatively reassuring: Rust's stability promises mean that even if something goes awry, they probably won't bork their installation, but they should understand there's a nonzero risk.
Steps
Possible Solution(s)
In order of estimated practicality and/or expedience:
Output of
rustup --version
:The text was updated successfully, but these errors were encountered: