-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Downgrading nightly toolchains #2067
Comments
I wonder if @jonhoo might have input on this? |
$ rustup component add --allow-downgrade miri |
UX aside, it's all the same pathway internally, so it'd go via your backtracking code @jonhoo :D I was more interested in what you thought about a bool to obviate the "stop at current version" check we currently have. |
I guess it seems okay to downgrade if the user explicitly asks for it 🤷♂️ |
Travis provides Rust environments for Nightly with: language: rust
rust:
- nightly This is great, unless you happen to require specific components for your builds. If you do, you'll need to uninstall the existing Rust version to be able to ensure rustup can install something that fulfills your requirements. This is from Intercom's current - rustup component add clippy rustfmt
- if( ! cargo clippy -V || ! cargo fmt --version ); then rustup uninstall nightly && rustup toolchain install nightly -c clippy -c rustfmt; fi
|
I'll look into it during RustFest, coordination through rust-lang discord #wg-rustup |
The PR mentions "rustup toolchain install --allow-downgrade", but what about "rustup component add --allow-downgrade" that was also mentioned above -- should a new issue be opened for that? |
@RalfJung It might make sense to create an issue around that, yes. The functionality is available via |
New issue opened: #2146 |
As talked on Discord with @kinnison
I think an interesting usecase is to be able to downgrade your nightly feature to one that supports specific toolchains.
i.e.
rustup toolchain install nightly --downgrade -c rustc -c rust-std -c cargo -c rustfmt -c clippy -c rls -c rust-analysis -c miri
This can make adding new components to your local toolchain easier (then tools like miri could add this to their docs and you won't need to uninstall latest nightly before installing this).
Another thing that this made me think of, maybe a way to aggregate components?
For example, I install
rustup toolchain install nightly -c cargo
and now I want to add miri support so by doing something likerustup toolchain install nightly --downgrade --add -c miri
It will now find me a toolchain with both clippy and miri.The text was updated successfully, but these errors were encountered: