Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generics3: Provide Grading Scale? #480

Closed
AndrooFrowns opened this issue Jul 27, 2020 · 4 comments
Closed

generics3: Provide Grading Scale? #480

AndrooFrowns opened this issue Jul 27, 2020 · 4 comments
Labels
A-exercises Area: Exercises C-feature-request Category: Feature Request

Comments

@AndrooFrowns
Copy link

While it's not technically required to implement the trait for the purpose of passing the tests, the instructions seem to imply familiarity with the 1.0 - > 5.5 grading scale. For many (myself included) this may not be true.

Would it be worth either changing to an exercise that doesn't rely on external knowledge, or to add in the information required to fully implement the grade scale?
@shadows-withal
Copy link
Member

@AndrewFrauens Yes! Good idea.

@shadows-withal shadows-withal added A-exercises Area: Exercises C-feature-request Category: Feature Request labels Jul 27, 2020
@VuiMuich
Copy link

I totally agree, that the description and the hint (see #625) is kind of vague and possibly misleading.
But you actually don't need information on how the different grading systems work, you simply can change the f32 of Gary Plotter's grade to a str to pass, so the description could simple mention this. (And the hint should probably loose the reference to implement a trait).

@keldonin
Copy link

keldonin commented Sep 2, 2021

Although I can agree with @VuiMuich that you could adapt the exercise, the source file assumes that everyone is used with the US grade system, and may present a challenge for people learning Rust who have now to cope with/guess a "foreign" grading system; this is probably diverting from the intent of the project. The least that could be done is to document within the source code what is the mapping between alphabetic grades and numerical ones. Or refer to an external resource (Wikipedia?)

@mo8it
Copy link
Contributor

mo8it commented Jul 10, 2024

Closing because the exercise (now quiz3) has been improved and the knowledge about the grading system is not required.

@mo8it mo8it closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-exercises Area: Exercises C-feature-request Category: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@keldonin @VuiMuich @shadows-withal @AndrooFrowns @mo8it