Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend inline_attribute_width to more AST types #5968

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Nov 28, 2023

Specifically: expressions, struct fields, and foreign ("extern") items.

xref #3343

See also #5538 (comment)

Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevyn thanks the PR. The implementation here makes sense to me, and I've left a suggestion for how we can better encapsulate the logic. Before we can move forward with this one I'd want to be more thorough with our test cases so we make sure we're not missing anything.

src/expr.rs Outdated Show resolved Hide resolved
tests/source/issue-3343.rs Outdated Show resolved Hide resolved
tests/source/issue-3343.rs Outdated Show resolved Hide resolved
@trevyn
Copy link
Contributor Author

trevyn commented Jul 5, 2024

@rustbot ready

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

Error: The feature shortcut is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants