Feature: add reorder_type_constraints option #5370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I find myself wondering if we"re going to end up needing to support additional flexibility as we"ve seen requested in other areas. I"ll write up my thoughts on the original issue for broader consideration and we can take it from there |
|
Going to mark this as on-hold for now as I think we need to get a clearer picture of what we"re trying to solve for before we can really proceed with the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5116
It reorders constraints on generics alphabetically. Treatment of comments interleaved with constraints is yet to be done.
Tips for improvements, special test cases, etc, are highly appreciated.
Thanks to @ytmimi for tips on how to implement this feature.