Toggle CFG_RELEASE_CHANNEL between nightly and stable on Windows, Linux, and Mac CI #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
changed the title
|
It's hitting me now that a downside of the in-test check and bail process we have makes it a bit tricky to know if the test passed after hitting all assertions, or whether it speciously bailed early 🤔 What would you think about temporarily updating one of the impacted tests so that it'll hit an assertion which we force to fail on stable, just to triple check this? Assuming that shows the expected failed job, we can flip back and move forward, and then perhaps in a followup try to find a different way of conditionally skipping tests dynamically |
calebcartwright
added
pr-waiting-on-author
and removed
pr-not-reviewed
pr-waiting-on-author
labels
|
Perfect, thanks! Feel free to revert the change and commit history, will merge afterwards |
ytmimi
force-pushed
the
nightly_and_stable_tests
branch
from
9c097b0
to
ea28722
Compare
calebcartwright
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to see if I can toggle the
CFG_RELEASE_CHANNELin CI to test some code that is only reachable whenCFG_RELEASE_CHANNELis not set tonightly