Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and speed up search for local path based deps with cargo fmt --all #4997

Merged

Conversation

calebcartwright
Copy link
Member

Resolves #4247

@calebcartwright calebcartwright force-pushed the simplify-local-dep-search branch from 37f8dd8 to 0b53ec4 Compare September 21, 2021 02:23
@calebcartwright calebcartwright force-pushed the simplify-local-dep-search branch from 0b53ec4 to 0096ec1 Compare September 21, 2021 02:27
@calebcartwright calebcartwright force-pushed the simplify-local-dep-search branch from 0096ec1 to 51a2f8a Compare September 24, 2021 01:19
@calebcartwright calebcartwright merged commit 4b9d637 into rust-lang:master Sep 24, 2021
@matklad
Copy link
Member

matklad commented Sep 24, 2021

LGTM!

Although I'd still say that we should be consistent with cargo with regards to --all handling. Even if some people do multi-crate projects without workspaces and want that workflow to be convenient, that's an argument for, eg, cargo test --all to follow path dependencies, and for cargo fmt to behave differently from built-in cargo commands.

@calebcartwright calebcartwright deleted the simplify-local-dep-search branch October 23, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo fmt --all is slow in a workspace project
2 participants