Keep the comment after where clause that has no predicate (#4649) #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that I looked through other place where |
|
If we use the approach in this PR to format |
|
Looks like this now has a lot of CI/test failures. Could you please take a look when you get a chance? |
|
The idempotent tests were ran against two different config; the current failure output looks like theis: Mismatch at tests/source/issue-4649.rs:7:
fn bar2(&self, a: T)
where
- /* Self: Bar */;
/* Self: Bar */;
}
Mismatch at tests/source/issue-4001.rs:1:
fn unit() -> ()
where
- /* comment */ {
/* comment */ {
()
}
But if I change the target snippet to match the outcome above, the failure output became: Mismatch at tests/source/issue-4649.rs:7:
fn bar2(&self, a: T)
where
- /* Self: Bar */;
/* Self: Bar */;
}
Mismatch at tests/target/issue-4649.rs:7:
fn bar2(&self, a: T)
where
- /* Self: Bar */;
/* Self: Bar */;
}
Mismatch at tests/source/issue-4001.rs:1:
fn unit() -> ()
where
- /* comment */ {
/* comment */ {
()
}
Mismatch at tests/target/issue-4001.rs:1:
fn unit() -> ()
where
- /* comment */ {
/* comment */ {
()
}
What are some way to circumvent this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request aims at solving #4649, and formats the comment that occurs before the where-clause; two cases are handled by the modified code:
whereexists but does not have any predicate: For this scenario, it would be great to have people's input on\nright afterwhere). Several test cases inissue_4649.rswould fail.wheredoes not exist. In this scenario, rustfmt behaves the same as before.Any suggestion is appreciated!