Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't force a newline after an empty where clause #4548

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix: don't force a newline after an empty where clause #4548

merged 1 commit into from
Nov 26, 2020

Conversation

meiomorphism
Copy link
Contributor

Fixes #4547.

This PR is based off of the rustfmt-1.4.28 branch, although it should be trivially portable to master, if you'd prefer. A new test file is included.

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@calebcartwright
Copy link
Member

This PR is based off of the rustfmt-1.4.28 branch, although it should be trivially portable to master, if you'd prefer. A new test file is included.

If you are interested and have the bandwidth, would you mind opening a separate PR against master? Will want to get this into a 1.x branch so it will be included in the currently-released versions of rustfmt, but also want to go ahead and get it fully fixed in source as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants