Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move keyword is eaten sometimes by rustfmt #53

Closed
oli-obk opened this issue Apr 30, 2015 · 3 comments
Closed

move keyword is eaten sometimes by rustfmt #53

oli-obk opened this issue Apr 30, 2015 · 3 comments
Labels
bug Panic, non-idempotency, invalid code, etc. good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Apr 30, 2015

the following code

fn main() {
    let _ = function(move || 5);
    let _ = move || 42;
}

is changed to

fn main() {
    let _ = function(|| 5);
    let _ = move || 42;
}

related: rust-lang/rust#24986
@nrc nrc added bug Panic, non-idempotency, invalid code, etc. good first issue Issues up for grabs, also good candidates for new rustfmt contributors and removed good first issue Issues up for grabs, also good candidates for new rustfmt contributors labels Apr 30, 2015
@nrc
Copy link
Member

nrc commented Apr 30, 2015

Probably not easy, actually, probably needs to fix the bug in libsyntax first

@oli-obk
Copy link
Contributor Author

oli-obk commented May 16, 2015

This is now fixed in rust master. Needs a regression test.

@nrc nrc added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label May 16, 2015
defyrlt added a commit to defyrlt/rustfmt that referenced this issue May 17, 2015
@defyrlt
Added regression test for rust-lang#53.
837dadd
@defyrlt defyrlt mentioned this issue May 17, 2015
Merged
nrc added a commit that referenced this issue May 17, 2015
@nrc
Merge pull request #70 from defyrlt/test_for_53
e38a672 
Added regression test for #53.
@nrc
Copy link
Member

nrc commented May 17, 2015

Fixed in #70

@oli-obk oli-obk closed this as completed May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Panic, non-idempotency, invalid code, etc. good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @nrc