Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long slice patterns are not getting wrapped #4530

Closed
erickt opened this issue Nov 16, 2020 · 0 comments · Fixed by #4994
Closed

Long slice patterns are not getting wrapped #4530

erickt opened this issue Nov 16, 2020 · 0 comments · Fixed by #4994
Assignees
@topecongiro
Labels
poor-formatting

Comments

@erickt
Copy link
Contributor

erickt commented Nov 16, 2020

It seems that rustfmt doesn't wrap long slice pattern lines.

Input

enum Foo {
    IAmALongVariantNameIJustKeepGoingOn { a: usize, b: usize },
}

fn main() {
    let foos = vec![Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }];

    match foos.as_slice() {
        [
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
        ] => {}
        _ => {}
    }
}

Output

enum Foo {
    IAmALongVariantNameIJustKeepGoingOn { a: usize, b: usize },
}

fn main() {
    let foos = vec![Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }];

    match foos.as_slice() {
        [Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }, Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }, Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }] =>
            {}
        _ => {}
    }
}

Expected output

enum Foo {
    IAmALongVariantNameIJustKeepGoingOn { a: usize, b: usize },
}

fn main() {
    let foos = vec![Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 }];

    match foos.as_slice() {
        [
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
            Foo::IAmALongVariantNameIJustKeepGoingOn { a: 0, b: 0 },
        ] => {}
        _ => {}
    }
}

Meta

  • rustfmt version: rustfmt 1.4.26-nightly (293d7d0 2020-11-14) and rustfmt 2.0.0-rc.2-nightly (8d68652 2020-11-14)
  • From where did you install rustfmt?: rustup, and built by hand
@calebcartwright calebcartwright mentioned this issue Nov 17, 2020
Merged
pcwalton added a commit to pcwalton/rustfmt-1 that referenced this issue Sep 18, 2021
@pcwalton
Wrap long array and slice patterns.
f27349a 
Closes rust-lang#4530.
@pcwalton pcwalton mentioned this issue Sep 18, 2021
Merged
pcwalton added a commit to pcwalton/rustfmt-1 that referenced this issue Sep 18, 2021
@pcwalton
Wrap long array and slice patterns.
cd09303 
Closes rust-lang#4530.
pcwalton added a commit to pcwalton/rustfmt-1 that referenced this issue Sep 18, 2021
@pcwalton
Wrap long array and slice patterns.
3e28fe4 
Closes rust-lang#4530.
pcwalton added a commit to pcwalton/rustfmt-1 that referenced this issue Oct 5, 2021
@pcwalton
Wrap long array and slice patterns.
7607d16 
Closes rust-lang#4530.
calebcartwright pushed a commit that referenced this issue Oct 5, 2021
@pcwalton @calebcartwright
Wrap long array and slice patterns.
f0f449d 
Closes #4530.
@IsaacShelton IsaacShelton mentioned this issue Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
poor-formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap long array and slice patterns. pcwalton/rustfmt-1
2 participants
@erickt @topecongiro