Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 3223 should be gated on the version number #3229

Closed
nrc opened this issue Dec 4, 2018 · 3 comments
Closed

PR 3223 should be gated on the version number #3229

nrc opened this issue Dec 4, 2018 · 3 comments
Labels
bug Panic, non-idempotency, invalid code, etc.

Comments

@nrc
Copy link
Member

nrc commented Dec 4, 2018

No description provided.

@nrc nrc added the bug Panic, non-idempotency, invalid code, etc. label Dec 4, 2018
@scampi
Copy link
Contributor

scampi commented Dec 6, 2018

@nrc what should be done to fix this ?

@topecongiro
Copy link
Contributor

Ouch. I forgot about versioning thing when I merged it... 😭

@scampi We need to address the following things:

  1. Gate this change on "version". Something like the following should be OK for now:
if config.version() == Version::One {
    // format in old way
} else {
    // format in new way
}
  1. Add tests to check that semicolons are added only when version is set to Two.
  2. (Optional) add "version" = "Two" to rustfmt.toml of this repo so that self-check uses the latest formatting.

@scampi
Copy link
Contributor

scampi commented Dec 13, 2018

@nrc @topecongiro sorry about that, i've been reading posts about rustfmt stabilisation but it didn't strike me either when writing the PR.
I'll fix this with the instructions above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc.
Projects
None yet
Development

No branches or pull requests

3 participants