Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default newline_style should be Native #2626

Closed
lzybkr opened this issue Apr 16, 2018 · 0 comments · Fixed by #2823
Closed

Default newline_style should be Native #2626

lzybkr opened this issue Apr 16, 2018 · 0 comments · Fixed by #2823
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors p-high

Comments

@lzybkr
Copy link

lzybkr commented Apr 16, 2018

The general guidance for Windows developers is to use core.autocrlf=true, so the default experience of running rustfmt on a Windows machine results in changing every single line.

It seems like the best experience would be to use newline_style = Native or else infer the newline style instead of changing the newline style.
@nrc nrc added good first issue Issues up for grabs, also good candidates for new rustfmt contributors p-high labels Jun 24, 2018
fwalch added a commit to fwalch/rustfmt that referenced this issue Jul 2, 2018
@fwalch
Change default newline style to "Native"
9d8f381 
Fixes rust-lang#2626.
@fwalch fwalch mentioned this issue Jul 4, 2018
Merged
@nrc nrc closed this as completed in #2823 Jul 16, 2018
@nrc nrc mentioned this issue Jul 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors p-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default newline style to "Native" fwalch/rustfmt
2 participants
@nrc @lzybkr