Add thiscall_abi to stable version Rust 1.73. #2661
Conversation
1.73 Changelog: - https://github.com/rust-lang/rust/releases/tag/1.73.0 Stabilization issue: - rust-lang/rust#114562
|
It would be good if you could add a test like https://github.com/rust-lang/rust-bindgen/blob/main/bindgen-tests/tests/headers/win32-thiscall_nightly.hpp and https://github.com/rust-lang/rust-bindgen/blob/main/bindgen-tests/tests/headers/win32-thiscall_1_0.hpp using |
|
Added a test case, copied from the nightly but with stable 1.73 instead. BTW, a bit off-topic, the |
|
It looks like there was some test that failed. I think that is because they are not obeying the The So if you use a non-nightly compiler, it will just skip the whole file and trivially succeed! I guess I could do a similar thing in my new |
|
Hi @pvdrz ! Any feedback about this PR? |
|
@rodrigorc can you fix the macos CI test? |
rodrigorc
force-pushed
the
Stabilize_thiscall_abi
branch
from
3188df9
to
5c14227
Compare
I just force-pushed a fix for that. I'm not totally sure if that is the proper solution, but I run it changing some things here and there and it looked mostly ok, but I don't have a macos, so I can't be sure about that part. |
1.73 Changelog:
Stabilization issue:
Maybe there are some tests to be fixed. I'm not quite sure how to review those.