fix: Fix double rounding of f32 literals
#17558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jul 8, 2024
crates/hir-def/src/hir.rs
Outdated
| #[derive(Default, Debug, Clone, Copy, Eq, PartialEq)] | ||
| pub struct FloatTypeWrapper(u64); | ||
| #[derive(Default, Debug, Clone, Eq, PartialEq)] | ||
| pub struct FloatTypeWrapper(String); |
There was a problem hiding this comment.
Suggested change
| pub struct FloatTypeWrapper(String); | |
| pub struct FloatTypeWrapper(Box<str>); |
let's use a boxed string to shrink the type a bit (and ensure no left over allocation)
Veykril
added
S-waiting-on-author
beetrees
force-pushed
the
fix-double-rounding
branch
from
b25f027
to
3200226
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17556 by delaying parsing until the type is known. Also adds a test to check the issue is fixed.