Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Move grammar codegen into xtask #16884

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 19, 2024

#14778, also threw in the one line fix for #13912

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2024
@Veykril
Copy link
Member Author

Veykril commented Mar 19, 2024

@bors r

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

📌 Commit b38d539 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

⌛ Testing commit b38d539 with merge 1c2d7d0...

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 1c2d7d0 to master...

@bors bors merged commit 1c2d7d0 into rust-lang:master Mar 19, 2024
11 checks passed
@lnicola
Copy link
Member

lnicola commented Mar 25, 2024

also threw in the one line fix for #13912

Hmm, I don't think that did anything: https://github.com/rust-lang/rust-analyzer/actions/runs/8416241510/job/23042626400.

@Veykril Veykril deleted the grammar-codegen branch September 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants