Quick fix for function no return value, `Ok()` out of function body #17728

A4-Tacks · 2024-07-28T10:33:38Z

rust-analyzer version: rust-analyzer 1.80.0 (05147895 2024-07-21)

rustc version: rustc 1.80.0 (051478957 2024-07-21)

editor or extension: Vim 9.1 coc-rust-analyzer

code snippet to reproduce:

type Result<T> = std::result::Result<T, ()>;

fn foo() -> Result<()> {}

fn main() { }

quick fix:

type Result<T> = std::result::Result<T, ()>;

fn foo() -> Result<()> Ok({})

fn main() { }

expect:

type Result<T> = std::result::Result<T, ()>;

fn foo() -> Result<()> { Ok(()) }

fn main() { }

A4-Tacks added the C-bug Category: bug label Jul 28, 2024

Veykril added the A-diagnostics diagnostics / error reporting label Jul 28, 2024

ShoyuVanilla mentioned this issue Aug 1, 2024

fix: Insert a tail Ok(()) for expr block instead of wrapping with Ok #17763

Merged

bors closed this as completed in f149dc5 Aug 1, 2024

Provide feedback