Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some of the macro expansion tests / add some standalone ones to hir-expand #17636

Open
Veykril opened this issue Jul 19, 2024 · 0 comments
Labels
A-infra CI and workflow issues A-macro macro expansion A-proc-macro proc macro C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented Jul 19, 2024

Currently all of them live in the hir-def crate, making use of nameresolution, but I believe we should have some tests within hir-expand that strictly only test the expansion parts. It feels wrong to me that they all live within hir-def (this also means we cant easily test a subset of r-a swapped to the new salsa for macro expansion if we wanted ;)

Kind of a funny stance as that goes directly against #10494 😬 I don't fully disagree, but I t think the issue at hand is more that we just have to little tests for macros. Some would make more sense within hir-def, some more in hir-expand.

@Veykril Veykril added A-macro macro expansion A-infra CI and workflow issues A-proc-macro proc macro C-enhancement Category: enhancement labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra CI and workflow issues A-macro macro expansion A-proc-macro proc macro C-enhancement Category: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant