Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move source gen tests from the main crates into xtask #14778

Closed
Veykril opened this issue May 10, 2023 · 1 comment
Closed

Move source gen tests from the main crates into xtask #14778

Veykril opened this issue May 10, 2023 · 1 comment
Labels
A-infra CI and workflow issues Broken Window Bugs / technical debt to be addressed immediately C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented May 10, 2023 •
edited
Loading

It is annoying for people that just want to do a doc fixup or config fixup having to build the entire crate or workspace just to run the source gen tests. We should look into moving these into xtask.
@Veykril Veykril added the C-enhancement Category: enhancement label May 10, 2023
@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Dec 18, 2023
@Veykril Veykril changed the title Disconnect source gen tests from the main crates were possible Move source gen tests from the main crates into xtask Dec 18, 2023
@Veykril Veykril added the A-infra CI and workflow issues label Dec 18, 2023
@Veykril Veykril mentioned this issue Mar 19, 2024
Merged
bors added a commit that referenced this issue Mar 19, 2024
@bors
Auto merge of #16884 - Veykril:grammar-codegen, r=Veykril
1c2d7d0 
internal: Move grammar codegen into xtask

#14778, also threw in the one line fix for #13912
@Veykril
Copy link
Member Author

Veykril commented Jul 7, 2024

Fixed with #17553

@Veykril Veykril closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infra CI and workflow issues Broken Window Bugs / technical debt to be addressed immediately C-enhancement Category: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Veykril