-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate all repositories #10307
Comments
It would be nice to preserve the full history of the merged repos. You could either use |
You've definitely thought about this, so can you articulate why you don't want to flatten everything into a single workspace? Your approach here somewhat seems to contradict your own article on managing large Rust workspaces. |
The physical reason here is that crates in So, we have independent versioning, and independent CI, and that's why we put them into |
Makes sense, thanks for expanding on that. |
This makes sense to me. 👍 for git subtree.
…On Wed, Sep 22, 2021, 6:58 AM Dirkjan Ochtman ***@***.***> wrote:
Makes sense, thanks for expanding on that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBACRCVAIG2RKJ4GFZ3CTDUDGZGRANCNFSM5EQTIVTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign=notification-email&utm_medium=email&utm_source=github>.
|
If there won't be any path dependencies, you could even limit the new CI jobs to only run when those crates are changed by a PR (and conversely, have some of the current CI jobs only run when part of the big workspace is touched, though this might be harder). |
We've moved the lsp-server into this repo, the other two I personally don't feel like we should move them in here (ungrammar maybe though I doubt that will really receive any more changes) |
rust-analyzer org has a bunch of repos. I feel that they all (except the main one) are neglected, at least by me -- I miss PRs, the r lists are not synced, there's no established workflows for smaller repos, etc. Additionally, if we are to move
rust-analyzer
to rust-lang, it's easier to move over just one repo.I suggest merging satellite repos into the main one, using the following stategy:
/libs
directorycargo test
in each of the smaller projectsSpecifically, I feel we should definitely merge
I am torn about https://github.com/rust-analyzer/rowan -- it feels big enough to be worthwhile to be a separate thing...
The text was updated successfully, but these errors were encountered: